On 10/19/2018 05:02 AM, Jose Abreu wrote: > Hello Andrew and Florian, > > Currently I have a 10G C45 phy that is fixed at 10G link. This > version does not support auto negotiation so I'm turning off the > feature in phydev struct field. I found out that when I do this > phylib is not composing C45 frames and is instead using C22. This > is due to call to genphy_udpate_link() which doesn't work on my > phy because it doesn't support C22. > > If I apply attached patch then things work perfectly fine. Can > you please review it ?
Looks reasonable, I could not find other functions in the state machine that were not already abstracting the clause type, or letting a driver callback be called. Can you submit this as a formal patch against net-next (and not attached, but inline)? I would suggest creating a helper, e.g: phy_update_link() that way everything is well namespaced and clear within the state machine itself. -- Florian
