From: Serhey Popovych <serhe.popov...@gmail.com>
Date: Tue,  9 Oct 2018 21:21:01 +0300

> Configuring generic network device parameters on tun will fail in
> presence of IFLA_INFO_KIND attribute in IFLA_LINKINFO nested attribute
> since tun_validate() always return failure.
> 
> This can be visualized with following ip-link(8) command sequences:
> 
>   # ip link set dev tun0 group 100
>   # ip link set dev tun0 group 100 type tun
>   RTNETLINK answers: Invalid argument
> 
> with contrast to dummy and veth drivers:
> 
>   # ip link set dev dummy0 group 100
>   # ip link set dev dummy0 type dummy
> 
>   # ip link set dev veth0 group 100
>   # ip link set dev veth0 group 100 type veth
> 
> Fix by returning zero in tun_validate() when @data is NULL that is
> always in case since rtnl_link_ops->maxtype is zero in tun driver.
> 
> Fixes: f019a7a594d9 ("tun: Implement ip link del tunXXX")
> Signed-off-by: Serhey Popovych <serhe.popov...@gmail.com>

Applied, thank you.

Reply via email to