On Mon, Oct 15, 2018 at 11:57:56AM -0700, Jakub Kicinski wrote: > On Sat, 13 Oct 2018 17:18:38 +0000, Ido Schimmel wrote: > > Add the ability to determine whether a netdev is a VxLAN netdev by > > calling the above mentioned function that checks the netdev's private > > flags. > > > > This will allow modules to identify netdev events involving a VxLAN > > netdev and act accordingly. For example, drivers capable of VxLAN > > offload will need to configure the underlying device when a VxLAN netdev > > is being enslaved to an offloaded bridge. > > > > Signed-off-by: Ido Schimmel <ido...@mellanox.com> > > Reviewed-by: Petr Machata <pe...@mellanox.com> > > Is this preferable over > > !strcmp(netdev->rtnl_link_ops->kind, "vxlan") > > which is what TC offloads do?
Using a flag seemed like the more standard way. That being said, we considered using net_device_ops instead, given we are about to run out of available private flags, so I don't mind adopting a technique already employed by another driver. P.S. Had to Cc netdev again. I think your client somehow messed the Cc list? I see Cc list in your reply, but with back slashes at the end of two email addresses.
