On 10/11/18 02:45 AM, Daniel Borkmann wrote:
> Convert kTLS over to make use of sk_msg interface for plaintext and
> encrypted scattergather data, so it reuses all the sk_msg helpers
> and data structure which later on in a second step enables to glue
> this to BPF.
Looks very clean, thanks!
>
> -static int zerocopy_from_iter(struct sock *sk, struct iov_iter *from,
> - int length, int *pages_used,
> - unsigned int *size_used,
> - struct scatterlist *to, int to_max_pages,
> - bool charge)
> -{
...
> - err = zerocopy_from_iter(sk, out_iov, data_len, &pages,
> - chunk, &sgout[1],
> - (n_sgout - 1), false);
> + err = tls_setup_from_iter(sk, out_iov, data_len,
> + &pages, chunk, &sgout[1],
> + (n_sgout - 1));
Any reason not to add the 'bool charge' to sk_msg_zerocopy_from_iter?
Then tls_setup_from_iter is not necessary.
