The ip_defrag.sh script requires bash-style output redirection but
use the default shell. This may cause random failures if the default
shell is not bash.
Address the above using posix compliant output redirection.

Fixes: 02c7f38b7ace ("selftests/net: add ip_defrag selftest")
Signed-off-by: Paolo Abeni <[email protected]>
---
 tools/testing/selftests/net/ip_defrag.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/net/ip_defrag.sh 
b/tools/testing/selftests/net/ip_defrag.sh
index 3a4042d918f0..f34672796044 100755
--- a/tools/testing/selftests/net/ip_defrag.sh
+++ b/tools/testing/selftests/net/ip_defrag.sh
@@ -11,10 +11,10 @@ readonly NETNS="ns-$(mktemp -u XXXXXX)"
 setup() {
        ip netns add "${NETNS}"
        ip -netns "${NETNS}" link set lo up
-       ip netns exec "${NETNS}" sysctl -w net.ipv4.ipfrag_high_thresh=9000000 
&> /dev/null
-       ip netns exec "${NETNS}" sysctl -w net.ipv4.ipfrag_low_thresh=7000000 
&> /dev/null
-       ip netns exec "${NETNS}" sysctl -w net.ipv6.ip6frag_high_thresh=9000000 
&> /dev/null
-       ip netns exec "${NETNS}" sysctl -w net.ipv6.ip6frag_low_thresh=7000000 
&> /dev/null
+       ip netns exec "${NETNS}" sysctl -w net.ipv4.ipfrag_high_thresh=9000000 
>/dev/null 2>&1
+       ip netns exec "${NETNS}" sysctl -w net.ipv4.ipfrag_low_thresh=7000000 
>/dev/null 2>&1
+       ip netns exec "${NETNS}" sysctl -w net.ipv6.ip6frag_high_thresh=9000000 
>/dev/null 2>&1
+       ip netns exec "${NETNS}" sysctl -w net.ipv6.ip6frag_low_thresh=7000000 
>/dev/null 2>&1
 }
 
 cleanup() {
-- 
2.17.2

Reply via email to