On 2018/10/9 18:13, David Howells wrote:
> YueHaibing <yuehaib...@huawei.com> wrote:
>
>> net/rxrpc/output.c: In function 'rxrpc_reject_packets':
>> net/rxrpc/output.c:527:11: warning:
>> variable 'ioc' set but not used [-Wunused-but-set-variable]
>>
>> It never used since introduction in
>
> I wonder why my compiler doesn't show this warning.
Just use make W=1
>
> Anyway, NAK: just removing the variable is the wrong fix - you need to look at
> the code more closely. The actual fix is to pass it to kernel_sendmsg()
> instead of 2.
I didn't notice this, Thank you for correction.
>
> But thanks anyway! Do you want to respin your patch?
Sure, I will fix it.
>
>> commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than
>> ABORTs")
>
> Btw, this should be a 'Fixes: <commit> ("subject")' line and the patch needs
> to go to net, not net-next.
>
> David
>
> .
>
