> > + if (err == -ENOENT)
> > + return NULL;
> > + else if (err)
> > + return ERR_PTR(err);
> > +
> > + if (args.args_count >= 1)
> > + port = args.args[0];
>
> If it's greater than one, than it is an error, and it should be flagged
> as such.
>
> The idea looks good though, should of_find_mii_timestamper() somehow be
> made conditional to CONFIG_PTP and we should have a stub for when it is
> disabled?
Hi Florian
There already is a stub. But register return -EOPNOTSUPP.
> > +
> > + return register_mii_timestamper(args.np, port);
So this returns EOPNOTUP
> > +}
> > +
> > static int of_mdiobus_register_phy(struct mii_bus *mdio,
> > struct device_node *child, u32 addr)
> > {
> > + struct mii_timestamper *mii_ts;
> > struct phy_device *phy;
> > bool is_c45;
> > int rc;
> > u32 phy_id;
> >
> > + mii_ts = of_find_mii_timestamper(child);
> > + if (IS_ERR(mii_ts))
> > + return PTR_ERR(mii_ts);
> > +
and this returns EOPNOPTSUPP, so the PHY is not registered :-(
Andrew
