On October 5, 2018 8:43:55 PM GMT+02:00, David Ahern <dsah...@gmail.com> wrote:
>On 10/5/18 11:36 AM, Christian Brauner wrote:
>>> diff --git a/include/linux/netlink.h b/include/linux/netlink.h
>>> index 88c8a2d83eb3..36bdca2aa42d 100644
>>> --- a/include/linux/netlink.h
>>> +++ b/include/linux/netlink.h
>>> @@ -179,6 +179,8 @@ struct netlink_callback {
>>> struct netlink_ext_ack *extack;
>>> u16 family;
>>> u16 min_dump_alloc;
>>> + unsigned int strict_check:1,
>>> + unused:31;
>>
>> I like this idea a lot. :) but I'm not a fan of bitfields if not
>> necessary. Is that really necessary here?
>>
>
>no strong opinions on a bitfield vs a bool.
Just feels like this is something that is
rarely used. Having a bool or traditional
flag might be more readable and easier to
maintain. :)
