On Sun, Sep 30, 2018 at 11:41:00AM +0300, Sergei Shtylyov wrote: > Hello! > > On 9/30/2018 12:04 AM, Andrew Lunn wrote: > > >The macro PHY_GBIT_FEAUTRES needs to change into a bitmap in order to > >support link_modes. Remove its use from xgde by replacing it with its > >definition. > > > >Probably, the current behavior is wrong. It probably should be > >ANDing not assigning. > > ORing, maybe?
Hi Sergei It is hard to know what was intended here. By assigning these speeds, if the PHY does not actually support 1Gbps, that information is going to be overwritten. So it should really be ANDing with that the MAC supports. ORing would have the same problem. This assignment is also clearing out an TP, AUI, BNC bits which might be set. Since i don't really know what the intention is here, i'm just going to leave it alone. > > >Signed-off-by: Andrew Lunn <and...@lunn.ch> > >--- > >v2 > >Remove unneeded () > > Really? :-) I did not say all unneeded :-) I will remove some more. Andrew
