> -----Original Message----- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Sergei Shtylyov > Sent: Friday, September 28, 2018 2:02 AM > To: Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com>; da...@davemloft.net > Cc: Keller, Jacob E <jacob.e.kel...@intel.com>; netdev@vger.kernel.org; > nhor...@redhat.com; sassm...@redhat.com; jogre...@redhat.com; > Venkataramanan, Anirudh <anirudh.venkatarama...@intel.com> > Subject: Re: [net-next 1/8] ice: use [sr]q.count when checking if queue is > initialized > > Hello! > > On 9/27/2018 7:21 PM, Jeff Kirsher wrote: > > > From: Jacob Keller <jacob.e.kel...@intel.com> > > > > When shutting down the controlqs, we check if they are initialized > > before we shut them down and destroy the lock. This is important, as it > > prevents attempts to access the lock of an already shutdown queue. > > > > Unfortunately, we checked rq.head and sq.head as the value to determine > > if the queue was initialized. This doesn't work, because head is not > > reset when the queue is shutdown. In some flows, the adminq will have > > already been shut down prior to calling ice_shutdown_all_ctrlqs. This > > can result in a crash due to attempting to access the already destroyed > > mutex. > > > > Fix this by using rq.count and sq.count instead. Indeed, ice_shutdown_sq > > and ice_shutdown_rq already indicate that this is the value we should be > > using to determine of the queue was initialized. > > s/of/if/?
Yes. However, unless there's a functional change required as well, I don't think it's worth fixing this. Thanks, Jake > > > Signed-off-by: Jacob Keller <jacob.e.kel...@intel.com> > > Signed-off-by: Anirudh Venkataramanan > <anirudh.venkatarama...@intel.com> > > Tested-by: Andrew Bowers <andrewx.bow...@intel.com> > > Signed-off-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com> > [...] > > MBR, Sergei
