> -----Original Message-----
> From: Stephen Hemminger <[email protected]>
> Sent: Saturday, September 29, 2018 8:53 AM
> To: [email protected]
> Cc: Stephen Hemminger <[email protected]>; Haiyang Zhang
> <[email protected]>; Eric Dumazet <[email protected]>
> Subject: [PATCH] hv_netvsc: remove ndo_poll_controller
> 
> Similar to other patches from ERic.
> 
> As diagnosed by Song Liu, ndo_poll_controller() can be very dangerous on
> loaded hosts, since the cpu calling ndo_poll_controller() might steal all NAPI
> contexts (for all RX/TX queues of the NIC). This capture can last for 
> unlimited
> amount of time, since one cpu is generally not able to drain all the queues
> under load.
> 
> In netvsc driver it uses NAPI for TX completions. The default poll_napi will 
> do
> this for us now and avoid the capture.
> 
> Signed-off-by: Stephen Hemminger <[email protected]>
> Cc: Haiyang Zhang <[email protected]>
> Cc: Eric Dumazet <[email protected]>
> ---

Thank you.
Reviewed-by: Haiyang Zhang <[email protected]>

Reply via email to