On 28.09.2018 22:19, Heiner Kallweit wrote:
> Some of the chip-specific hw_start functions set bit TXCFG_AUTO_FIFO
> in register TxConfig. The original patch changed the order of some
> calls resulting in these changes being overwritten by
> rtl_set_tx_config_registers() in rtl_hw_start(). This eventually
> resulted in network stalls especially under high load.
>
> Analyzing the chip-specific hw_start functions all chip version from
> 34, with the exception of version 39, need this bit set.
> This patch moves setting this bit to rtl_set_tx_config_registers().
>
> Fixes: 4fd48c4ac0a0 ("r8169: move common initializations to tp->hw_start")
> Reported-by: Ortwin Glück <[email protected]>
> Reported-by: David Arendt <[email protected]>
> Tested-by: Tony Atkinson <[email protected]>
> Tested-by: David Arendt <[email protected]>
> Tested-by: Ortwin Glück <[email protected]>
> Signed-off-by: Heiner Kallweit <[email protected]>
Please add:
Root-caused-by: Maciej S. Szmigiero <[email protected]>
Thanks,
Maciej
