phy_suspend doesn't always recognize that WoL is enabled and therefore suspends the PHY when it should not. First idea to address the issue was to reuse checks used in mdio_bus_phy_may_suspend which check whether relevant devices are wakeup-enabled. Florian raised some concerns because drivers may enable wakeup even if WoL isn't enabled (e.g. certain USB network drivers).
The new approach focuses on reducing the risk to break existing stuff. We add a flag wol_enabled to struct net_device which is set in ethtool_set_wol(). Then this flag is checked in phy_suspend(). This doesn't cover 100% of the cases yet (e.g. if WoL is enabled w/o explicit configuration), but it covers the most relevant cases with very little risk of regressions. v2: - Fix a typo Heiner Kallweit (2): net: core: add member wol_enabled to struct net_device net: phy: fix WoL handling when suspending the PHY drivers/net/phy/phy_device.c | 12 +++++++++--- include/linux/netdevice.h | 3 +++ net/core/ethtool.c | 9 ++++++++- 3 files changed, 20 insertions(+), 4 deletions(-) -- 2.19.0
