On 9/21/18 10:58 AM, Eric Dumazet wrote:
> net/ipv4/fib_frontend.c: In function 'fib_info_nh_uses_dev':
> net/ipv4/fib_frontend.c:322:6: error: unused variable 'ret'
> [-Werror=unused-variable]
> cc1: all warnings being treated as errors
>
> Fixes: 78f2756c5fc0 ("net/ipv4: Move device validation to helper")
> Signed-off-by: Eric Dumazet <[email protected]>
> Cc: David Ahern <[email protected]>
> ---
> net/ipv4/fib_frontend.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
> index
> 222b968de94cbff98c4a1b4a2f298b2e68452984..30e2bcc3ef2a293568076228fecf3cf07ba01f20
> 100644
> --- a/net/ipv4/fib_frontend.c
> +++ b/net/ipv4/fib_frontend.c
> @@ -318,9 +318,9 @@ __be32 fib_compute_spec_dst(struct sk_buff *skb)
> bool fib_info_nh_uses_dev(struct fib_info *fi, const struct net_device *dev)
> {
> bool dev_match = false;
> +#ifdef CONFIG_IP_ROUTE_MULTIPATH
> int ret;
>
> -#ifdef CONFIG_IP_ROUTE_MULTIPATH
> for (ret = 0; ret < fi->fib_nhs; ret++) {
> struct fib_nh *nh = &fi->fib_nh[ret];
>
>
Reviewed-by: David Ahern <[email protected]>
Thanks for the fix.
