On Tuesday, September 09/18/18, 2018 at 11:39:14 -0700, Jakub Kicinski wrote: > On Tue, 18 Sep 2018 18:37:23 +0530, Arjun Vynipadath wrote: > > Forcing link up of virtual interfaces even when physical link is down > > causes packet drops and ping failures during bonding failover. Hence > > adding a ethtool private flag to toggle force_link_up whenever required. > > > > Signed-off-by: Arjun Vynipadath <ar...@chelsio.com> > > Signed-off-by: Casey Leedom <lee...@chelsio.com> > > Signed-off-by: Ganesh Goudar <ganes...@chelsio.com> > > Could you describe how this mechanism relates to the existing > ndo_set_vf_link_state, which you seem to not make use of: > > $ git grep ndo_set_vf_link_state -- drivers/net/ethernet/chelsio/ > $ > > I understand you're configuring the setting from the VF side, but the > question, as always, is: why ;) Hi Jakub, ndo_set_vf_link_state can't be presently used in our case. We dont have firmware support to communicate the link flags set through ndo_set_vf_link_state from pf (cxgb4) driver to vf (cxgb4vf) driver.
Thanks, Arjun.