From: Cong Wang <xiyou.wangc...@gmail.com> Date: Mon, 10 Sep 2018 18:27:26 -0700
> When a rds sock is bound, it is inserted into the bind_hash_table > which is protected by RCU. But when releasing rds sock, after it > is removed from this hash table, it is freed immediately without > respecting RCU grace period. This could cause some use-after-free > as reported by syzbot. > > Mark the rds sock with SOCK_RCU_FREE before inserting it into the > bind_hash_table, so that it would be always freed after a RCU grace > period. > > The other problem is in rds_find_bound(), the rds sock could be > freed in between rhashtable_lookup_fast() and rds_sock_addref(), > so we need to extend RCU read lock protection in rds_find_bound() > to close this race condition. > > Reported-and-tested-by: syzbot+8967084bcac563795...@syzkaller.appspotmail.com > Reported-by: syzbot+93a5839deb3555374...@syzkaller.appspotmail.com > Cc: Sowmini Varadhan <sowmini.varad...@oracle.com> > Cc: Santosh Shilimkar <santosh.shilim...@oracle.com> > Cc: rds-de...@oss.oracle.com > Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com> Applied and queued up for -stable, thanks.
