On 09/12/2018 01:32 AM, Andrew Lunn wrote: >> compatible = "marvell,mv88e6352", "marvell,mv88e6085"; > > Just "marvell,mv88e6085"; > > Please take a look at all the other DT files using the Marvell > chips. You will only ever find "marvell,mv88e6085" or > "marvell,mv88e6190", because everything is compatible to one of these > two.
Well, until you find a difference between those chips which you cannot discern based solely on the ID register content. Then it's better to have a compatible to match on which matches the actual chip. You can always patch the code to handle the difference between those chips based on the extra DT information, but you cannot always patch the DT itself, since it can be in ROM or whatnot. -- Best regards, Marek Vasut
