On Tue, 4 Sep 2018 18:59:57 +0200 Jakub Kicinski <jakub.kicin...@netronome.com> wrote:
> On Tue, 4 Sep 2018 18:49:33 +0200, Jesper Dangaard Brouer wrote: > > On Tue, 4 Sep 2018 17:09:12 +0200 > > Jakub Kicinski <jakub.kicin...@netronome.com> wrote: > > > > > On Tue, 04 Sep 2018 16:59:19 +0200, Jesper Dangaard Brouer wrote: > > > > Trying to use XDP hardware offloading via XDP_FLAGS_HW_MODE > > > > and setting the ifindex in prog_load_attr.ifindex before > > > > loading the BPF code via bpf_prog_load_xattr(). > > > > > > > > This unfortunately does not seem to work... > > > > - Am I doing something wrong? > > > > > > > > Notice, I also disable the map BPF_MAP_TYPE_PERCPU_ARRAY > > > > to make sure it was not related to the map (not supporting > > > > offloading). > > > > > > > > Failed with: > > > > # ./xdp1 -O $(</sys/class/net/enp130s0np1/ifindex) > > > > libbpf: load bpf program failed: Invalid argument > > > > libbpf: failed to load program 'xdp1' > > > > libbpf: failed to load object './xdp1_kern.o' > > > > > > > > Tested on kernel 4.18.0-2.el8.x86_64 with driver nfp > > > > Ethernet controller: Netronome Systems, Inc. Device 4000 > > > > > > Are you running the BPF capable FW? > > > > > > https://help.netronome.com/support/solutions/articles/36000050009-agilio-ebpf-2-0-6-extended-berkeley-packet-filter > > > > > > > I'm likely not running the correct firmware... > > > > Can you tell me, with the ethtool -i output, if I'm running the > > appropriate firmware? > > > > # ethtool -i enp129s0np1 > > driver: nfp > > version: 4.18.0-2.el8.x86_64 SMP mod_unl > > firmware-version: 0.0.3.5 0.21 nic-2.0.7 nic > > expansion-rom-version: > > bus-info: 0000:81:00.0 > > supports-statistics: yes > > supports-test: no > > supports-eeprom-access: no > > supports-register-dump: yes > > supports-priv-flags: no > > Yup, the BPF firmware says bpf in firmware version. Downloaded: agilio-bpf-firmware-2.0.6.121-1.noarch.rpm RPM install it: rpm -hiv agilio-bpf-firmware-2.0.6.121-1.noarch.rpm # rpm -ql agilio-bpf-firmware /opt/netronome/firmware/agilio-bpf /opt/netronome/firmware/agilio-bpf/nic_AMDA0058-0011_2x40.nffw /opt/netronome/firmware/agilio-bpf/nic_AMDA0058-0012_2x40.nffw /opt/netronome/firmware/agilio-bpf/nic_AMDA0078-0011_1x100.nffw /opt/netronome/firmware/agilio-bpf/nic_AMDA0081-0001_1x40.nffw /opt/netronome/firmware/agilio-bpf/nic_AMDA0081-0001_4x10.nffw /opt/netronome/firmware/agilio-bpf/nic_AMDA0096-0001_2x10.nffw /opt/netronome/firmware/agilio-bpf/nic_AMDA0097-0001_2x40.nffw /opt/netronome/firmware/agilio-bpf/nic_AMDA0097-0001_4x10_1x40.nffw /opt/netronome/firmware/agilio-bpf/nic_AMDA0097-0001_8x10.nffw /opt/netronome/firmware/agilio-bpf/nic_AMDA0099-0001_1x10_1x25.nffw /opt/netronome/firmware/agilio-bpf/nic_AMDA0099-0001_2x10.nffw /opt/netronome/firmware/agilio-bpf/nic_AMDA0099-0001_2x25.nffw Netronome: Basic Firmware User Guide https://help.netronome.com/support/solutions/articles/36000049975-basic-firmware-user-guide A section says after installing the firmware, unload and reload the driver kernel module will upgrade the firmware. ## reload driver to load new firmware rmmod nfp; modprobe nfp Firmware upgrade worked! :-) This is by-far the easiest firmware upgrade I've experienced. And I don't have to reboot the machine :-) # ethtool -i enp130s0np1 | grep firmware-version firmware-version: 0.0.3.5 0.21 bpf-2.0.6.121 ebpf Notice the bpf/ebpf strings in firmware-version. > > If this is a firmware version case, then we should really improve the > > errors we are giving the user, the -EINVAL can be anything. > > > > "libbpf: load bpf program failed: Invalid argument" > > That is true. Same goes for improving the error message, when loading a map type that offload cannot handle. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer
