On 31/08/2018 2:29 PM, Konstantin Khlebnikov wrote:
XOR (MLX5_RX_HASH_FN_INVERTED_XOR8) gives only 8 bits.
It seems not enough for RFS. All other drivers use toeplitz.
Driver mlx4_en uses Toeplitz by default and warns if hash XOR is used
together with NETIF_F_RXHASH (enabled by default too): "Enabling both
XOR Hash function and RX Hashing can limit RPS functionality".
XOR is default in mlx5_en since commit 2be6967cdbc9
("net/mlx5e: Support ETH_RSS_HASH_XOR").
Hash function could be set via ethtool. But it would be nice to have
single standard for drivers or proper description why this one is special.
Signed-off-by: Konstantin Khlebnikov <khlebni...@yandex-team.ru>
---
Hi Konstantin,
Thanks for the patch.
I understand the motivation.
This change affects the default out-of-the-box behavior and requires a
full performance cycle. We'll run performance regression tomorrow,
results should be ready by EOW.
I'll update.
Regards,
Tariq
