Den fre 31 aug. 2018 kl 03:02 skrev Prashant Bhole <[email protected]>: > > Since xdp_umem_query() was added one assignment of bpf.command was > missed from cleanup. Removing the assignment statement. >
Good catch! Acked-by: Björn Töpel <[email protected]> > Fixes: 84c6b86875e01a0 ("xsk: don't allow umem replace at stack level") > Signed-off-by: Prashant Bhole <[email protected]> > --- > net/xdp/xdp_umem.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/xdp/xdp_umem.c b/net/xdp/xdp_umem.c > index bfe2dbea480b..d179732617dc 100644 > --- a/net/xdp/xdp_umem.c > +++ b/net/xdp/xdp_umem.c > @@ -76,8 +76,6 @@ int xdp_umem_assign_dev(struct xdp_umem *umem, struct > net_device *dev, > if (!dev->netdev_ops->ndo_bpf || !dev->netdev_ops->ndo_xsk_async_xmit) > return force_zc ? -EOPNOTSUPP : 0; /* fail or fallback */ > > - bpf.command = XDP_QUERY_XSK_UMEM; > - > rtnl_lock(); > err = xdp_umem_query(dev, queue_id); > if (err) { > -- > 2.17.1 > >
