On Fri, Aug 24, 2018 at 06:58:38AM -0400, rpj...@crashcourse.ca wrote:
> just pedantry here ... was perusing include/linux/netdevice.h, and in the
> declaration for struct net_device, the kerneldoc, one reads:
>
> * @flags: Interface flags (a la BSD)
> * @priv_flags: Like 'flags' but invisible to userspace,
> * see if.h for the definitions
>
> assuming "if.h" means include/uapi/linux/if.h, there is nothing in that
> file explaining the *private* flags; rather, the private flags appear
> to be explained earlier in netdevice.h -- it's the *normal* flags that
> seem to be defined in if.h.
The flag definitions were moved from include/uapi/linux/if.h to
include/linux/netdevice.h by commit 7aa98047df95 ("net: move net_device
priv_flags out from UAPI"). The comment is outdated - it was actually
written when the definitions were still in include/linux/if.h (before
the UAPI split). You may want to submit a patch fixing (or removing) it.
Michal Kubecek
