On 08/21/2018 03:34 PM, Andrew Lunn wrote:
> I don't see where this is happening. It is looking for a gpio called
> 'link-gpios'.
First while registering the MDIO bus in __mdiobus_register:
gpiod = devm_gpiod_get_optional(&bus->dev, "reset", GPIOD_OUT_LOW);
and then again when registering the fixed-link in mdiobus_register_gpiod:
gpiod = fwnode_get_named_gpiod(&mdiodev->dev.of_node->fwnode,
"reset-gpios", 0, GPIOD_OUT_LOW,
"PHY reset");
>> But regardless, there shouldn't have been an of_mdiobus_register and a MDIO
>> bus probe
>> before registering the fixed-link in the first place and my patch remedies
>> that.
>
> There are cases where you need both, e.g a switch controller over
> MDIO. So we cannot make it one or the other.
I see.
> However, there are currently no such boards. So far "net", lets go
> with your partial revert patch.
I will resend the first patch.
> But we also need patches for
> "net-next" which put it back again, allows both fixed-link and an
> mdiobus inside a subnode, and not break backwards compatibility.
I'll resend the remainder when net-next opens again.
Cheers
Ahmad
