We are trying to test if these flags are set but there are some && vs &
typos.

Fixes: efd1ba6af93f ("net: dsa: mv88e6xxx: Add SERDES phydev_mac_change up for 
6390")
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>

diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c 
b/drivers/net/dsa/mv88e6xxx/serdes.c
index f007d109b385..e82983975754 100644
--- a/drivers/net/dsa/mv88e6xxx/serdes.c
+++ b/drivers/net/dsa/mv88e6xxx/serdes.c
@@ -502,8 +502,8 @@ static irqreturn_t mv88e6390_serdes_thread_fn(int irq, void 
*dev_id)
                err = mv88e6390_serdes_irq_status_sgmii(chip, lane, &status);
                if (err)
                        goto out;
-               if (status && (MV88E6390_SGMII_INT_LINK_DOWN ||
-                              MV88E6390_SGMII_INT_LINK_UP)) {
+               if (status & (MV88E6390_SGMII_INT_LINK_DOWN |
+                             MV88E6390_SGMII_INT_LINK_UP)) {
                        ret = IRQ_HANDLED;
                        mv88e6390_serdes_irq_link_sgmii(chip, port->port, lane);
                }

Reply via email to