On Mon, 16 Oct 2006, David Miller wrote: > From: Per Liden <[EMAIL PROTECTED]> > Date: Fri, 13 Oct 2006 13:37:23 +0200 (CEST) > > > This patch set includes a number TIPC fixes/cleanups. Please see each > > individual patch for further description. > > > > Please pull from: > > > > git://tipc.cslab.ericsson.net/pub/git/tipc.git > > > > (rebased on linux/kernel/git/davem/net-2.6.git) > > I applied everything except patch 8/14, you really need to > add proper SKB queue locking to handle that race. I think > the "performance cost" of taking that lock is much overstated, > you should never have contention on that lock at all.
Ok, we'll take your advice on this. > Secondly, I never pull from your trees because I still have > to make many fixups to your patches: > > 1) Please add a proper colon to your changeset header lines, > it should be "[TIPC]: ", not "[TIPC] ". > > 2) Please check for trailing whitespace added by your patches. > I've given you the command you can use in another email to > check this for yourselve before submission. > > 3) Please get full proper signed-off-by lines from patch submitters, > especially when the patch is more than a trivial 1 or 2 liner. Thanks a lot for the feedback. We'll do our best to assure that we follow these rules in the future. /Per - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
