> -----Original Message----- > From: Dave Watson [mailto:davejwat...@fb.com] > Sent: Thursday, August 9, 2018 9:56 PM > To: Vakul Garg <vakul.g...@nxp.com> > Cc: netdev@vger.kernel.org; bor...@mellanox.com; > avia...@mellanox.com; da...@davemloft.net > Subject: Re: [PATCH net-next v2 1/1] net/tls: Combined memory allocation > for decryption request > > On 08/09/18 04:56 AM, Vakul Garg wrote: > > For preparing decryption request, several memory chunks are required > > (aead_req, sgin, sgout, iv, aad). For submitting the decrypt request > > to an accelerator, it is required that the buffers which are read by > > the accelerator must be dma-able and not come from stack. The buffers > > for aad and iv can be separately kmalloced each, but it is inefficient. > > This patch does a combined allocation for preparing decryption request > > and then segments into aead_req || sgin || sgout || iv || aad. > > > > Signed-off-by: Vakul Garg <vakul.g...@nxp.com> > > Reviewed-by: Dave Watson <davejwat...@fb.com> > > Thanks, looks good to me now.
I had to rebase the patch so as not to use any other patch which is under review. Since Doron's skb_nsg() patch needs rework, I submitted v3 after removing reference to function skb_nsg() and replaced it with skb_cow_data(). Kindly review.
