Hello Wei.
On 08/08/2018 04:43 AM, Wei Yongjun wrote:
> The return value from kzalloc() is not checked correctly. The
> test is done against a wrong variable. This patch fix it.
>
> Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb")
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/net/ieee802154/mac802154_hwsim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ieee802154/mac802154_hwsim.c
> b/drivers/net/ieee802154/mac802154_hwsim.c
> index 1982308..04f4100 100644
> --- a/drivers/net/ieee802154/mac802154_hwsim.c
> +++ b/drivers/net/ieee802154/mac802154_hwsim.c
> @@ -564,7 +564,7 @@ static int hwsim_set_edge_lqi(struct sk_buff *msg, struct
> genl_info *info)
> }
>
> einfo = kzalloc(sizeof(*einfo), GFP_KERNEL);
> - if (!info) {
> + if (!einfo) {
> mutex_unlock(&hwsim_phys_lock);
> return -ENOMEM;
> }
>
Thanks a lot for finding and fixing these two bugs!
Signed-off-by: Stefan Schmidt <[email protected]>
regards
Stefan Schmidt
