Am 08.08.2018 um 14:32 schrieb Ben Whitten: >>> drivers/net/lora/Kconfig | 1 + >>> drivers/net/lora/sx1301.c | 282 >> +++++++++++++++++++++++++++++++++++++++++++--- >>> drivers/net/lora/sx1301.h | 169 >> +++++++++++++++++++++++++++ >>> 3 files changed, 439 insertions(+), 13 deletions(-) >>> create mode 100644 drivers/net/lora/sx1301.h >> >> My main concern about this patch is its sheer size. Normally >> for >> #defines the rule is not to add unused ones. Here I see for >> example FSK >> RSSI fields that we're surely not using yet. Any chance to >> strip this >> down some more? > > Sure, I'll strip the reg_fields down to those only required for > loading firmware and setting clocks that will be used in the > immediate term. This does clutter the driver a bit > unnecessarily at the moment. > I would like to keep the full register dump in the header file > though as its self-contained and gives a full picture of the chip.
Could you do that in more steps though? I'm thinking, convert only the registers in use to regmap (that'll make it easier to review), then add more registers, then convert to regmap fields? Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)
