On Wed, Aug 08, 2018 at 01:57:15PM +0300, Igor Russkikh wrote: > Signed-off-by: Igor Russkikh <igor.russk...@aquantia.com> > --- > drivers/net/ethernet/aquantia/atlantic/ver.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/aquantia/atlantic/ver.h > b/drivers/net/ethernet/aquantia/atlantic/ver.h > index 94efc64..b482601 100644 > --- a/drivers/net/ethernet/aquantia/atlantic/ver.h > +++ b/drivers/net/ethernet/aquantia/atlantic/ver.h > @@ -12,7 +12,7 @@ > > #define NIC_MAJOR_DRIVER_VERSION 2 > #define NIC_MINOR_DRIVER_VERSION 0 > -#define NIC_BUILD_DRIVER_VERSION 3 > +#define NIC_BUILD_DRIVER_VERSION 4 > #define NIC_REVISION_DRIVER_VERSION 0 > > #define AQ_CFG_DRV_VERSION_SUFFIX "-kern"
Hi Igor Driver versions are pretty much useless. Say somebody backports this driver into a vendor kernel. Vendor kernels are typically based on an old kernel, plus thousands of patches. Is 2.0.4 on such a kernel the same as 2.0.4 in 4.19? You probably want to remove this, just the avoid people thinking is means something. Andrew