for (i = 0; i < 2048; i++) {
...
req->l2t_idx = htonl(V_L2T_W_IDX(i));
...
in there is very odd; l2t_idx is a 16bit field, and
#define V_L2T_W_IDX(x) ((x) << S_L2T_W_IDX)
#define S_L2T_W_IDX 0
IOW, we are taking htonl(something in range 0..2047) and
shove it into 16bit field. Which would, on a little-endian
host, be a fancy way of spelling
req->l2t_idx = 0;
What's the intended behaviour there? I'm not familiar with
the hardware in question; this smells like a typoed
req->l2t_idx = htons(...)
but how does the current code manage to work (i.e. does
anything even care about the value stored there)? It's not
a big-endian-only driver, after all...
