On 08/03/2018 08:50 AM, Jose Abreu wrote:
> Add the DMA related callbacks for the new IP block XGMAC2.
>
> Signed-off-by: Jose Abreu <[email protected]>
> Cc: David S. Miller <[email protected]>
> Cc: Joao Pinto <[email protected]>
> Cc: Giuseppe Cavallaro <[email protected]>
> Cc: Alexandre Torgue <[email protected]>
> ---
> + value &= ~XGMAC_RD_OSR_LMT;
> + value |= (axi->axi_rd_osr_lmt << XGMAC_RD_OSR_LMT_SHIFT) &
> + XGMAC_RD_OSR_LMT;
> +
> + for (i = 0; i < AXI_BLEN; i++) {
> + if (axi->axi_blen[i])
> + value &= ~XGMAC_UNDEF;
Should not you be you clearing all XGMAC_BLEN* values since you do a
logical or here? I am assuming this is not something that would likely
change from one open/close but still?
--
Florian
