On 02-08-2018 15:36, Andrew Lunn wrote: >> Sorry, I made a mistake. Where it reads SGMII in my reply I was >> referring to XGMII. > So you have XGMII between the MAC and the PHY. That should support > 2.5G, 5G and 10G. What i don't know is if you can also do 10/100/1000 > over XGMII?
Acording to databook I can only do 1G/2.5G and 10G. > > How are you currently connecting your 1G PHY to the MAC? XGMII is a > big parallel bus, where as SGMII is a small serial bus. I will check with HW team because I've no idea how is this connected ... > > I would say, before this patchset goes anywhere, you need to test > 10/100/1000/2.5G/10G, with at least one PHY. > > Alternatively, take out support for 2.5G/10G and C45, and post patches > for just > 1G and C22. That you can test and you know works. You can > add the rest later. Looks like a plan. So, I will remove the adjust_link speed selection for > 1g and the C45 support. I will leave the SS selection in dwxgmac2_core_init (patch 2/9) as this makes no difference because only 1g will be selected for now. I will also clearly refer in cover letter the BW results for 1g tests. Later on I will add support for 10g once shipping arrives. Looks okay? Thanks and Best Regards, Jose Miguel Abreu > > Andrew
