On 07/30/2018 03:30 PM, Andrew Lunn wrote: >> One usability issue with this approach is that one cannot specify >> wake-on-LAN using WAKE_MAGICSECURE *and* WAKE_FILTER at the same time, >> since it uses the same location in the ioctl() structure that is being >> passed. Do you see this as a problem? > > Hi Florian > > Maybe you can think ahead to when ethtool gets a netlink > implementation, and you have more flexibility to pass both as > attributes? How does this affect the in kernel API?
The thing is that I need this now, but when Michal's work on ethtool being migrated to netlink settles, we should have have any issues adding a proper storage area for specifying filters anymore. The issue here is of course that the size and layout of ethtool_wolinfo is largely fixed and set in stone, and therefore inflexible. -- Florian
