On Wed, Jul 25, 2018 at 03:36:47PM -0700, Nathan Harold wrote: > > diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c > index b669262682c9..ee212a7c91a9 100644 > --- a/net/xfrm/xfrm_state.c > +++ b/net/xfrm/xfrm_state.c > @@ -815,10 +815,10 @@ xfrm_init_tempstate(struct xfrm_state *x, const struct > flowi *fl, > afinfo->init_temprop(x, tmpl, daddr, saddr); > } > > -static struct xfrm_state *__xfrm_state_lookup(struct net *net, u32 mark, > - const xfrm_address_t *daddr, > - __be32 spi, u8 proto, > - unsigned short family) > +static struct xfrm_state * > +__xfrm_state_lookup(struct net *net, u32 mark, u32 mask, > + const xfrm_address_t *daddr, > + __be32 spi, u8 proto, unsigned short family)
The argument list of these functions are getting longer and longer. Can't you just put in a pointer to struct xfrm_mark and dereference inside the function? Looks good otherwise.
