From: Al Viro
Sent: Wednesday, 25 July, 7:19 AM
Subject: Re: [PATCH net-next] net/tls: Do not call msg_data_left() twice
To: Vakul Garg
Cc: netdev@vger.kernel.org, bor...@mellanox.com, avia...@mellanox.com,
davejwat...@fb.com, da...@davemloft.net
On Tue, Jul 24, 2018 at 04:41:18PM +0530, Vakul Garg wrote: > In function
tls_sw_sendmsg(), msg_data_left() needs to be called only > once. The second
invocation of msg_data_left() for assigning variable > try_to_copy can be
removed and merged with the first one. You do realize that msg_data_left(msg)
is simply msg->msg_iter.count? So I'm not at all sure that your change will be
an overall win...
Agreed, msg_data_left is inexpensive. It's just that is pointless to call it
again.
