On Thu, Jul 19, 2018 at 11:23 AM Nishanth Devarajan <ndev2...@gmail.com> wrote: > +static int skbprio_change(struct Qdisc *sch, struct nlattr *opt, > + struct netlink_ext_ack *extack) > +{ > + struct skbprio_sched_data *q = qdisc_priv(sch); > + struct tc_skbprio_qopt *ctl = nla_data(opt); > + const unsigned int min_limit = 1; > + > + if (ctl->limit == (typeof(ctl->limit))-1) > + sch->limit = max(qdisc_dev(sch)->tx_queue_len, min_limit);
I am sorry, I still don't like this use of tx_queue_len, it either should be removed or just align to other existing use cases. Apologize for responding to your previous email so late.