Re: [PATCH v3 net-next 7/8] lan743x: Add EEE support

[Andrew Lunn]

> +     if (eee->eee_enabled) {
> +             ret = phy_init_eee(phydev, 0);
> +             if (ret) {
> +                     netif_err(adapter, drv, adapter->netdev,
> +                               "EEE initialization failed\n");
> +                     return ret;
> +             }
> +
> +             buf = lan743x_csr_read(adapter, MAC_CR);
> +             buf |= MAC_CR_EEE_EN_;
> +             lan743x_csr_write(adapter, MAC_CR, buf);
> +
> +             phy_ethtool_set_eee(phydev, eee);

Hi Bryan

It could return an error, so please check the return value. Maybe move
this call out of the if to keep the code minimal?

     Andrew