Re: [RFC PATCH 3/3] net: macb: add support for padding and fcs computation

[David Miller]

From: Claudiu Beznea <claudiu.bez...@microchip.com>
Date: Wed, 18 Jul 2018 15:58:09 +0300

>  
> +static int macb_pad_and_fcs(struct sk_buff **skb, struct net_device *ndev)
> +{
> +     struct sk_buff *nskb;
> +     int padlen = ETH_ZLEN - (*skb)->len;
> +     int headroom = skb_headroom(*skb);
> +     int tailroom = skb_tailroom(*skb);
> +     bool cloned = skb_cloned(*skb) || skb_header_cloned(*skb);
> +     u32 fcs;

Please keep local variable ordered from longest to shortest line
(ie. reverse christmas tree format).

Thank you.