On 07/18/2018 10:42 AM, Daniel Borkmann wrote:
> On 07/18/2018 02:27 AM, Jakub Kicinski wrote:
>> On Wed, 18 Jul 2018 01:31:22 +0200, Daniel Borkmann wrote:
>>> # bpftool map dump id 386
>>> [{
>>> "key": 0,
>>> "value": {
>>> "": {
>>> "value": 0,
>>> "ifindex": 0,
>>> "mac": []
>>> }
>>> }
>>> },{
>>> "key": 1,
>>> "value": {
>>> "": {
>>> "value": 0,
>>> "ifindex": 0,
>>> "mac": []
>>> }
>>> }
>>> },{
>>> [...]
>>
>> Ugh, the empty keys ("") look worrying, we should probably improve
>> handling of anonymous structs in bpftool :S
>
> Yeah agree, I think it would be nice to see a more pahole style dump
> where we have types and member names along with the value as otherwise
> it might be a bit confusing.
Another feature that would be super useful imho would be in the /single/
map view e.g. 'bpftool map show id 123' to have a detailed BTF key+value
type dump, so in addition to the basic map info we show pahole like info
of the structs with length/offsets.
>> FWIW all the patches look nice to me! Thanks for keeping the support
>> for loading programs from the ".text" section :)
>
> The test_offload.py from BPF kselftests helped a lot in that! :)
>
> Thanks,
> Daniel
>
