Re: [PATCH net] net/ipv6: Do not allow device only routes via the multipath API

[Stefano Brivio]

On Thu, 12 Jul 2018 14:48:23 -0700
dsah...@kernel.org wrote:

> @@ -4388,6 +4388,13 @@ static int ip6_route_multipath_add(struct fib6_config 
> *cfg,
>                       rt = NULL;
>                       goto cleanup;
>               }
> +             if (!rt6_qualify_for_ecmp(rt)) {
> +                     err = EINVAL;

Shouldn't this be -EINVAL, just for consistency? E.g. we might return a
-ENOMEM from ip6_route_info_append(), etc.

-- 
Stefano