On 10.07.2018 23:00, Andrew Lunn wrote:
>> @@ -6719,7 +6703,7 @@ static int r8169_phy_connect(struct rtl8169_private 
>> *tp)
>>      if (ret)
>>              return ret;
>>  
>> -    if (!tp->mii.supports_gmii && phydev->supported & PHY_1000BT_FEATURES) {
>> +    if (!tp->supports_gmii && phydev->supported & PHY_1000BT_FEATURES) {
> 
> It is better to use phy_set_max_speed() with SPEED_100 if
> tp->supports_gmii is not set.
> 
Then the info message wouldn't fit any longer, it's meaningful in case
1GBit PHY + 100MBit MAC only.

>         Andrew
> 

Reply via email to