> -----Original Message----- > From: Cong Wang [mailto:[email protected]] > Sent: Tuesday, July 10, 2018 1:32 PM > To: Keller, Jacob E <[email protected]> > Cc: Linux Kernel Network Developers <[email protected]>; Eric Dumazet > <[email protected]> > Subject: Re: [net] sch_fq_codel: zero q->flows_cnt when fq_codel_init fails > > On Mon, Jul 9, 2018 at 8:37 AM Jacob Keller <[email protected]> wrote: > > +alloc_failure: > > + kfree(q->flows); > > You need to call kvfree() instead. > > Other than this, > > Acked-by: Cong Wang <[email protected]> > > For net-next, I will send a patch to skip ->reset() for ->init() failure > case, there is no reason to reset queues since qdisc is not even > activated.
Thanks, I sent a v2. Regards, Jake
