> static void r8168_pll_power_down(struct rtl8169_private *tp) > { > if (r8168_check_dash(tp)) > @@ -4503,7 +4462,8 @@ static void r8168_pll_power_down(struct rtl8169_private > *tp) > if (rtl_wol_pll_power_down(tp)) > return; > > - r8168_phy_power_down(tp); > + /* cover the case that PHY isn't connected */ > + phy_suspend(mdiobus_get_phy(tp->mii_bus, 0));
I don't particularly like this, because no other MAC driver does it. Why is it powered up, but not connected? Is it powered down before it is disconnected? Is it the bootloader which is powering it up? Andrew