From: Edward Cree <ec...@solarflare.com> Date: Fri, 6 Jul 2018 18:01:04 +0100
> A couple of bugs in skb list handling were spotted by Dan Carpenter, with > the help of Smatch; following up on them I found a couple more similar > cases. This series fixes them by changing the relevant loops to use the > dequeue-enqueue model (rather than in-place list modification), and then > adds a list.h helper macro to refactor code using the dequeue-enqueue > model. Edward, I think the helper added in patch #3 is not all that great. It can be even more confusing to understand what the code is doing in my opinion. I am pretty sure more hackers would need to go and read the macro definition in list.h before understanding what the read side effects of it are. Would you please resubmit this series including only patches #1 and #2? Thank you.
