Hi Boris, I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Boris-Pismenny/TLS-offload-rx-netdev-mlx5/20180705-064704 config: x86_64-randconfig-s1-07051503 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 Note: it may well be a FALSE warning. FWIW you are at least aware of it now. http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings All warnings (new ones prefixed by >>): net//tls/tls_sw.c: In function 'decrypt_skb_update': >> net//tls/tls_sw.c:685:9: warning: 'err' may be used uninitialized in this >> function [-Wmaybe-uninitialized] return err; ^~~ vim +/err +685 net//tls/tls_sw.c c46234eb Dave Watson 2018-03-22 659 13000621 Boris Pismenny 2018-07-04 660 static int decrypt_skb_update(struct sock *sk, struct sk_buff *skb, 13000621 Boris Pismenny 2018-07-04 661 struct scatterlist *sgout) 13000621 Boris Pismenny 2018-07-04 662 { 13000621 Boris Pismenny 2018-07-04 663 struct tls_context *tls_ctx = tls_get_ctx(sk); 13000621 Boris Pismenny 2018-07-04 664 struct tls_sw_context_rx *ctx = tls_sw_ctx_rx(tls_ctx); 13000621 Boris Pismenny 2018-07-04 665 struct strp_msg *rxm = strp_msg(skb); 13000621 Boris Pismenny 2018-07-04 666 int err; 13000621 Boris Pismenny 2018-07-04 667 52ffb3bf Boris Pismenny 2018-07-04 668 #ifdef CONFIG_TLS_DEVICE 52ffb3bf Boris Pismenny 2018-07-04 669 err = tls_device_decrypted(sk, skb); 52ffb3bf Boris Pismenny 2018-07-04 670 if (err < 0) 52ffb3bf Boris Pismenny 2018-07-04 671 return err; 52ffb3bf Boris Pismenny 2018-07-04 672 #endif 52ffb3bf Boris Pismenny 2018-07-04 673 if (!ctx->decrypted) { 13000621 Boris Pismenny 2018-07-04 674 err = decrypt_skb(sk, skb, sgout); 13000621 Boris Pismenny 2018-07-04 675 if (err < 0) 13000621 Boris Pismenny 2018-07-04 676 return err; 52ffb3bf Boris Pismenny 2018-07-04 677 } 13000621 Boris Pismenny 2018-07-04 678 13000621 Boris Pismenny 2018-07-04 679 rxm->offset += tls_ctx->rx.prepend_size; 13000621 Boris Pismenny 2018-07-04 680 rxm->full_len -= tls_ctx->rx.overhead_size; 13000621 Boris Pismenny 2018-07-04 681 tls_advance_record_sn(sk, &tls_ctx->rx); 13000621 Boris Pismenny 2018-07-04 682 ctx->decrypted = true; 13000621 Boris Pismenny 2018-07-04 683 ctx->saved_data_ready(sk); 13000621 Boris Pismenny 2018-07-04 684 13000621 Boris Pismenny 2018-07-04 @685 return err; 13000621 Boris Pismenny 2018-07-04 686 } 13000621 Boris Pismenny 2018-07-04 687 :::::: The code at line 685 was first introduced by commit :::::: 1300062159ee8551834a4371379b82abe20f436e tls: Split decrypt_skb to two functions :::::: TO: Boris Pismenny <bor...@mellanox.com> :::::: CC: 0day robot <l...@intel.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
