On Wed, Jun 27, 2018 at 8:45 PM Jesus Sanchez-Palencia
<jesus.sanchez-palen...@intel.com> wrote:
>
> The qdisc and the SO_TXTIME ABIs allow for a clockid to be configured,
> but it's been decided that usage of CLOCK_TAI should be enforced until
> we decide to allow for other clockids to be used. The rationale here is
> that PTP times are usually in the TAI scale, thus no other clocks should
> be necessary.
>
> For now, the qdisc will return EINVAL if any clocks other than
> CLOCK_TAI are used.
>
> Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palen...@intel.com>
> ---
> net/sched/sch_etf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/sched/sch_etf.c b/net/sched/sch_etf.c
> index cd6cb5b69228..5514a8aa3bd5 100644
> --- a/net/sched/sch_etf.c
> +++ b/net/sched/sch_etf.c
> @@ -56,8 +56,8 @@ static inline int validate_input_params(struct tc_etf_qopt
> *qopt,
> return -ENOTSUPP;
> }
>
> - if (qopt->clockid >= MAX_CLOCKS) {
> - NL_SET_ERR_MSG(extack, "Invalid clockid");
> + if (qopt->clockid != CLOCK_TAI) {
> + NL_SET_ERR_MSG(extack, "Invalid clockid. CLOCK_TAI must be
> used");
Similar to the comment in patch 12, this should be squashed (into
patch 6) to avoid incorrect behavior in a range of SHA1s.
