On 01/25/2018 06:26 PM, Cong Wang wrote:
> This patch promotes the local change_tx_queue_len() to a core
> helper function, dev_change_tx_queue_len(), so that rtnetlink
> and net-sysfs could share the code. This also prepares for the
> following patch.
>
> Note, the -EFAULT in the original code doesn't make sense,
> we should propagate the errno from notifiers.
>
> Cc: John Fastabend <john.fastab...@gmail.com>
> Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
> ---
> include/linux/netdevice.h | 1 +
> net/core/dev.c | 28 ++++++++++++++++++++++++++++
> net/core/net-sysfs.c | 25 +------------------------
> net/core/rtnetlink.c | 18 +++++-------------
> 4 files changed, 35 insertions(+), 37 deletions(-)
>
Hi Cong
What about using dev_change_tx_queue_len() helper from SIOCSIFTXQLEN path in
net/core/dev_ioctl.c ?
This would make sure we call dev_qdisc_change_tx_queue_len() in this case.
Thanks !
