Hi John,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    
https://github.com/0day-ci/linux/commits/Jakub-Kicinski/nfp-MPLS-and-shared-blocks-TC-offload-fixes/20180626-042358
config: x86_64-randconfig-u0-06260533 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/net/ethernet/netronome/nfp/bpf/main.c: In function 
'nfp_bpf_setup_tc_block':
>> drivers/net/ethernet/netronome/nfp/bpf/main.c:205:6: error: implicit 
>> declaration of function 'tcf_block_shared' 
>> [-Werror=implicit-function-declaration]
     if (tcf_block_shared(f->block))
         ^
   cc1: some warnings being treated as errors

vim +/tcf_block_shared +205 drivers/net/ethernet/netronome/nfp/bpf/main.c

   196  
   197  static int nfp_bpf_setup_tc_block(struct net_device *netdev,
   198                                    struct tc_block_offload *f)
   199  {
   200          struct nfp_net *nn = netdev_priv(netdev);
   201  
   202          if (f->binder_type != TCF_BLOCK_BINDER_TYPE_CLSACT_INGRESS)
   203                  return -EOPNOTSUPP;
   204  
 > 205          if (tcf_block_shared(f->block))
   206                  return -EOPNOTSUPP;
   207  
   208          switch (f->command) {
   209          case TC_BLOCK_BIND:
   210                  return tcf_block_cb_register(f->block,
   211                                               nfp_bpf_setup_tc_block_cb,
   212                                               nn, nn);
   213          case TC_BLOCK_UNBIND:
   214                  tcf_block_cb_unregister(f->block,
   215                                          nfp_bpf_setup_tc_block_cb,
   216                                          nn);
   217                  return 0;
   218          default:
   219                  return -EOPNOTSUPP;
   220          }
   221  }
   222  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to