On Mon, Jun 25, 2018 at 5:09 PM, Ido Schimmel <ido...@idosch.org> wrote: > Hi Xin, > > On Mon, Jun 25, 2018 at 10:45:08AM +0800, Xin Long wrote: >> This patch implements the feature described in rfc1812#section-5.3.5.2 >> and rfc2644. It allows the router to forward directed broadcast when >> sysctl mc_forwarding is enabled. > > You mean bc_forwarding? yes, typo, bc_forwarding.
> >> >> Note that this feature could be done by iptables -j TEE, but it would >> cause some problems: >> - target TEE's gateway param has to be set with a specific address, >> and it's not flexible especially when the route wants forward all >> directed broadcasts. >> - this duplicates the directed broadcasts so this may cause side >> effects to applications. >> >> Besides, to keep consistent with other os router like BSD, it's also >> necessary to implement it in the route rx path. > > Regarding the test you posted later in the thread, did you consider > adding it as part of tools/testing/selftests/net/forwarding/ ? I believe > you can write the test using VRFs instead of name spaces. didn't know that, but sounds good, will have a try. :) Thanks. > > Thanks
