> -----Original Message-----
> From: Ivan Vecera [mailto:[email protected]]
> Sent: Friday, June 08, 2018 2:20 AM
> To: [email protected]
> Cc: [email protected]; Keller, Jacob E <[email protected]>
> Subject: [PATCH ethtool 2/6] ethtool: fix RING_VF assignment
>
> Fixes: 36ee712 ("ethtool: support queue and VF fields for rxclass filters")
> Cc: Jacob Keller <[email protected]>
> Signed-off-by: Ivan Vecera <[email protected]>
> ---
> rxclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rxclass.c b/rxclass.c
> index ce4b382..42d122d 100644
> --- a/rxclass.c
> +++ b/rxclass.c
> @@ -1066,7 +1066,7 @@ static int rxclass_get_val(char *str, unsigned char *p,
> u32 *flags,
> val++;
>
> *(u64 *)&p[opt->offset] &=
> ~ETHTOOL_RX_FLOW_SPEC_RING_VF;
> - *(u64 *)&p[opt->offset] = (u64)val <<
> ETHTOOL_RX_FLOW_SPEC_RING_VF_OFF;
> + *(u64 *)&p[opt->offset] |= (u64)val <<
> ETHTOOL_RX_FLOW_SPEC_RING_VF_OFF;
> break;
> }
Hah. Good catch.
Thanks,
Jake
> case OPT_RING_QUEUE: {
> --
> 2.16.4
