On Tue, 2018-06-05 at 08:04 -0400, Yafang Shao wrote: > In ip receive path, when ip header hasn't been pulled yet, ip_hdr() and > skb->data are pointing to the same byte. > > In ip output path, when ip header is just pushed, ip_hdr() and skb->data > are pointing to the same byte. > > As ip_hdr() is more expensive than using skb->data, so replace ip_hdr() > with skb->data in these situations for optimization.
IMHO this makes the code less readable and more error prone. Which kind of performance improvement do you measure here? Thanks, Paolo
